Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update examples to use addService #367

Merged
merged 1 commit into from
Nov 10, 2018
Merged

update examples to use addService #367

merged 1 commit into from
Nov 10, 2018

Conversation

mitchdraft
Copy link
Contributor

small change to the samples now that the node server api has changed

link to api: https://github.com/grpc/grpc-node/blob/master/packages/grpc-native-core/src/server.js#L948

the examples work with or without this change, but the change removes this warning message:

$ node server.js
(node:44083) DeprecationWarning: Server#addProtoService: Use Server#addService instead

complimentary PR submitted on docs repo:
grpc/grpc.github.io#776

stanley-cheung
stanley-cheung approved these changes Nov 10, 2018
View reviewed changes
Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@stanley-cheung stanley-cheung merged commit 63dac01 into grpc:master Nov 10, 2018
@snyk-bot snyk-bot mentioned this pull request Mar 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Assignees
No one assigned
Labels
release notes: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchdraft @stanley-cheung @kokoro-team